Unverified Commit bd0f7498 authored by Kuninori Morimoto's avatar Kuninori Morimoto Committed by Mark Brown
Browse files

ASoC: ams-delta.c: use component after check 



	static void cx81801_close()
	{
		...
(A)		struct snd_soc_dapm_context *dapm = &component->card->dapm;
		...
(B)		if (!component)
			return;
	}

(A) uses component before NULL check (B). This patch moves it after (B).

Fixes: d0fdfe34 ("ASoC: cx20442: replace codec to component")
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/3e608474-e99a-4866-ae98-3054a4221f09@moroto.mountain


Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87ttqdq623.wl-kuninori.morimoto.gx@renesas.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent a65cdffb

sound/soc/ti/ams-delta.c

+3 −1
Original line number Diff line number Diff line
@@ -301,7 +301,7 @@ static int cx81801_open(struct tty_struct *tty) 
static void cx81801_close(struct tty_struct *tty)

{

	struct snd_soc_component *component = tty->disc_data;

	struct snd_soc_dapm_context *dapm = &component->card->dapm;

	struct snd_soc_dapm_context *dapm;



	del_timer_sync(&cx81801_timer);
@@ -313,6 +313,8 @@ static void cx81801_close(struct tty_struct *tty) 


	v253_ops.close(tty);



	dapm = &component->card->dapm;



	/* Revert back to default audio input/output constellation */

	snd_soc_dapm_mutex_lock(dapm);