Commit bd4da046 authored by Youling Tang's avatar Youling Tang Committed by Kent Overstreet
Browse files

bcachefs: Move the ei_flags setting to after initialization 



`inode->ei_flags` setting and cleaning should be done after initialization,
otherwise the operation is invalid.

Fixes: 9ca4853b ("bcachefs: Fix quota support for snapshots")
Signed-off-by: default avatarYouling Tang <tangyouling@kylinos.cn>
Signed-off-by: default avatarKent Overstreet <kent.overstreet@linux.dev>
parent 2fe79ce7

fs/bcachefs/fs.c

+3 −5
Original line number Diff line number Diff line
@@ -1497,11 +1497,6 @@ static void bch2_vfs_inode_init(struct btree_trans *trans, subvol_inum inum, 
	bch2_iget5_set(&inode->v, &inum);

	bch2_inode_update_after_write(trans, inode, bi, ~0);



	if (BCH_SUBVOLUME_SNAP(subvol))

		set_bit(EI_INODE_SNAPSHOT, &inode->ei_flags);

	else

		clear_bit(EI_INODE_SNAPSHOT, &inode->ei_flags);



	inode->v.i_blocks	= bi->bi_sectors;

	inode->v.i_ino		= bi->bi_inum;

	inode->v.i_rdev		= bi->bi_dev;
@@ -1513,6 +1508,9 @@ static void bch2_vfs_inode_init(struct btree_trans *trans, subvol_inum inum, 
	inode->ei_qid		= bch_qid(bi);

	inode->ei_subvol	= inum.subvol;



	if (BCH_SUBVOLUME_SNAP(subvol))

		set_bit(EI_INODE_SNAPSHOT, &inode->ei_flags);



	inode->v.i_mapping->a_ops = &bch_address_space_operations;



	switch (inode->v.i_mode & S_IFMT) {