Commit bd587829 authored by Breno Leitao's avatar Breno Leitao Committed by Andrew Morton
Browse files

vmcoreinfo: make hwerr_data visible for debugging 

If the kernel is compiled with LTO, hwerr_data symbol might be lost, and
vmcoreinfo doesn't have it dumped.  This is currently seen in some
production kernels with LTO enabled.

Remove the static qualifier from hwerr_data so that the information is
still preserved when the kernel is built with LTO.  Making hwerr_data a
global symbol ensures its debug info survives the LTO link process and
appears in kallsyms.  Also document it, so it doesn't get removed in
the future as suggested by akpm.

Link: https://lkml.kernel.org/r/20260122-fix_vmcoreinfo-v2-1-2d6311f9e36c@debian.org


Fixes: 3fa805c3 ("vmcoreinfo: track and log recoverable hardware errors")
Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Acked-by: default avatarBaoquan He <bhe@redhat.com>
Cc: Dave Young <dyoung@redhat.com>
Cc: "Luck, Tony" <tony.luck@intel.com>
Cc: Omar Sandoval <osandov@osandov.com>
Cc: Shuai Xue <xueshuai@linux.alibaba.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: Zhiquan Li <zhiquan1.li@intel.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 12b2285b

kernel/vmcore_info.c

+5 −1
Original line number Diff line number Diff line
@@ -36,7 +36,11 @@ struct hwerr_info { 
	time64_t timestamp;

};



static struct hwerr_info hwerr_data[HWERR_RECOV_MAX];

/*

 * The hwerr_data[] array is declared with global scope so that it remains

 * accessible to vmcoreinfo even when Link Time Optimization (LTO) is enabled.

 */

struct hwerr_info hwerr_data[HWERR_RECOV_MAX];



Elf_Word *append_elf_note(Elf_Word *buf, char *name, unsigned int type,

			  void *data, size_t data_len)