Commit bddf3094 authored by Qianfeng Rong's avatar Qianfeng Rong Committed by Alex Deucher
Browse files

drm/amd/pm: use int type to store negative error codes 



Use int instead of uint32_t for 'ret' variable to store negative error
codes or zero returned by other functions.

Storing the negative error codes in unsigned type, doesn't cause an issue
at runtime but can be confusing. Additionally, assigning negative error
codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
flag is enabled.

No effect on runtime.

Signed-off-by: default avatarQianfeng Rong <rongqianfeng@vivo.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent a0556587

drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c

+1 −1
Original line number Diff line number Diff line
@@ -1032,7 +1032,7 @@ static int smu10_print_clock_levels(struct pp_hwmgr *hwmgr, 
			data->clock_vol_info.vdd_dep_on_fclk;

	uint32_t i, now, size = 0;

	uint32_t min_freq, max_freq = 0;

	uint32_t ret = 0;

	int ret = 0;



	switch (type) {

	case PP_SCLK:

drivers/gpu/drm/amd/pm/powerplay/smumgr/smu7_smumgr.c

+1 −1
Original line number Diff line number Diff line
@@ -401,7 +401,7 @@ int smu7_request_smu_load_fw(struct pp_hwmgr *hwmgr) 
int smu7_check_fw_load_finish(struct pp_hwmgr *hwmgr, uint32_t fw_type)

{

	struct smu7_smumgr *smu_data = (struct smu7_smumgr *)(hwmgr->smu_backend);

	uint32_t ret;

	int ret;



	ret = phm_wait_on_indirect_register(hwmgr, mmSMC_IND_INDEX_11,

					smu_data->soft_regs_start + smum_get_offsetof(hwmgr,

drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c

+1 −1
Original line number Diff line number Diff line
@@ -470,7 +470,7 @@ static int renoir_od_edit_dpm_table(struct smu_context *smu, 
static int renoir_set_fine_grain_gfx_freq_parameters(struct smu_context *smu)

{

	uint32_t min = 0, max = 0;

	uint32_t ret = 0;

	int ret = 0;



	ret = smu_cmn_send_smc_msg_with_param(smu,

								SMU_MSG_GetMinGfxclkFrequency,