Commit be054cc6 authored by Ruitong Liu's avatar Ruitong Liu Committed by Jakub Kicinski
Browse files

net/sched: act_skbedit: fix divide-by-zero in tcf_skbedit_hash() 



Commit 38a6f086 ("net: sched: support hash selecting tx queue")
added SKBEDIT_F_TXQ_SKBHASH support. The inclusive range size is
computed as:

mapping_mod = queue_mapping_max - queue_mapping + 1;

The range size can be 65536 when the requested range covers all possible
u16 queue IDs (e.g. queue_mapping=0 and queue_mapping_max=U16_MAX).
That value cannot be represented in a u16 and previously wrapped to 0,
so tcf_skbedit_hash() could trigger a divide-by-zero:

queue_mapping += skb_get_hash(skb) % params->mapping_mod;

Compute mapping_mod in a wider type and reject ranges larger than U16_MAX
to prevent params->mapping_mod from becoming 0 and avoid the crash.

Fixes: 38a6f086 ("net: sched: support hash selecting tx queue")
Cc: stable@vger.kernel.org # 6.12+
Signed-off-by: default avatarRuitong Liu <cnitlrt@gmail.com>
Link: https://patch.msgid.link/20260213175948.1505257-1-cnitlrt@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a07c33c6

net/sched/act_skbedit.c

+5 −1
Original line number Diff line number Diff line
@@ -126,7 +126,7 @@ static int tcf_skbedit_init(struct net *net, struct nlattr *nla, 
	struct tcf_skbedit *d;

	u32 flags = 0, *priority = NULL, *mark = NULL, *mask = NULL;

	u16 *queue_mapping = NULL, *ptype = NULL;

	u16 mapping_mod = 1;

	u32 mapping_mod = 1;

	bool exists = false;

	int ret = 0, err;

	u32 index;
@@ -194,6 +194,10 @@ static int tcf_skbedit_init(struct net *net, struct nlattr *nla, 
			}



			mapping_mod = *queue_mapping_max - *queue_mapping + 1;

			if (mapping_mod > U16_MAX) {

				NL_SET_ERR_MSG_MOD(extack, "The range of queue_mapping is invalid.");

				return -EINVAL;

			}

			flags |= SKBEDIT_F_TXQ_SKBHASH;

		}

		if (*pure_flags & SKBEDIT_F_INHERITDSFIELD)