Commit be0c40da authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda/realtek: Add quirk for HP Spectre x360 15-df1xxx 

HP Spectre x360 15-df1xxx with SSID 13c:863e requires similar
workarounds that were applied to another HP Spectre x360 models;
it has a mute LED only, no micmute LEDs, and needs the speaker GPIO
seup.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=220054
Link: https://patch.msgid.link/20250427081035.11567-1-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent e8fa236e

sound/pci/hda/patch_realtek.c

+42 −0
Original line number Diff line number Diff line
@@ -6982,6 +6982,41 @@ static void alc285_fixup_hp_spectre_x360_eb1(struct hda_codec *codec, 
	}

}



/* GPIO1 = amplifier on/off */

static void alc285_fixup_hp_spectre_x360_df1(struct hda_codec *codec,

					     const struct hda_fixup *fix,

					     int action)

{

	struct alc_spec *spec = codec->spec;

	static const hda_nid_t conn[] = { 0x02 };

	static const struct hda_pintbl pincfgs[] = {

		{ 0x14, 0x90170110 },  /* front/high speakers */

		{ 0x17, 0x90170130 },  /* back/bass speakers */

		{ }

	};



	// enable mute led

	alc285_fixup_hp_mute_led_coefbit(codec, fix, action);



	switch (action) {

	case HDA_FIXUP_ACT_PRE_PROBE:

		/* needed for amp of back speakers */

		spec->gpio_mask |= 0x01;

		spec->gpio_dir |= 0x01;

		snd_hda_apply_pincfgs(codec, pincfgs);

		/* share DAC to have unified volume control */

		snd_hda_override_conn_list(codec, 0x14, ARRAY_SIZE(conn), conn);

		snd_hda_override_conn_list(codec, 0x17, ARRAY_SIZE(conn), conn);

		break;

	case HDA_FIXUP_ACT_INIT:

		/* need to toggle GPIO to enable the amp of back speakers */

		alc_update_gpio_data(codec, 0x01, true);

		msleep(100);

		alc_update_gpio_data(codec, 0x01, false);

		break;

	}

}



static void alc285_fixup_hp_spectre_x360(struct hda_codec *codec,

					  const struct hda_fixup *fix, int action)

{
@@ -7780,6 +7815,7 @@ enum { 
	ALC280_FIXUP_HP_9480M,

	ALC245_FIXUP_HP_X360_AMP,

	ALC285_FIXUP_HP_SPECTRE_X360_EB1,

	ALC285_FIXUP_HP_SPECTRE_X360_DF1,

	ALC285_FIXUP_HP_ENVY_X360,

	ALC288_FIXUP_DELL_HEADSET_MODE,

	ALC288_FIXUP_DELL1_MIC_NO_PRESENCE,
@@ -9857,6 +9893,10 @@ static const struct hda_fixup alc269_fixups[] = { 
		.type = HDA_FIXUP_FUNC,

		.v.func = alc285_fixup_hp_spectre_x360_eb1

	},

	[ALC285_FIXUP_HP_SPECTRE_X360_DF1] = {

		.type = HDA_FIXUP_FUNC,

		.v.func = alc285_fixup_hp_spectre_x360_df1

	},

	[ALC285_FIXUP_HP_ENVY_X360] = {

		.type = HDA_FIXUP_FUNC,

		.v.func = alc285_fixup_hp_envy_x360,
@@ -10588,6 +10628,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = { 
	SND_PCI_QUIRK(0x103c, 0x86c1, "HP Laptop 15-da3001TU", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),

	SND_PCI_QUIRK(0x103c, 0x86c7, "HP Envy AiO 32", ALC274_FIXUP_HP_ENVY_GPIO),

	SND_PCI_QUIRK(0x103c, 0x86e7, "HP Spectre x360 15-eb0xxx", ALC285_FIXUP_HP_SPECTRE_X360_EB1),

	SND_PCI_QUIRK(0x103c, 0x863e, "HP Spectre x360 15-df1xxx", ALC285_FIXUP_HP_SPECTRE_X360_DF1),

	SND_PCI_QUIRK(0x103c, 0x86e8, "HP Spectre x360 15-eb0xxx", ALC285_FIXUP_HP_SPECTRE_X360_EB1),

	SND_PCI_QUIRK(0x103c, 0x86f9, "HP Spectre x360 13-aw0xxx", ALC285_FIXUP_HP_SPECTRE_X360_MUTE_LED),

	SND_PCI_QUIRK(0x103c, 0x8716, "HP Elite Dragonfly G2 Notebook PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
@@ -11520,6 +11561,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = { 
	{.id = ALC295_FIXUP_HP_OMEN, .name = "alc295-hp-omen"},

	{.id = ALC285_FIXUP_HP_SPECTRE_X360, .name = "alc285-hp-spectre-x360"},

	{.id = ALC285_FIXUP_HP_SPECTRE_X360_EB1, .name = "alc285-hp-spectre-x360-eb1"},

	{.id = ALC285_FIXUP_HP_SPECTRE_X360_DF1, .name = "alc285-hp-spectre-x360-df1"},

	{.id = ALC285_FIXUP_HP_ENVY_X360, .name = "alc285-hp-envy-x360"},

	{.id = ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP, .name = "alc287-ideapad-bass-spk-amp"},

	{.id = ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN, .name = "alc287-yoga9-bass-spk-pin"},