Commit be16b46f authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Jakub Kicinski
Browse files

ptp: ocp: constify 'struct bin_attribute' 



The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Reviewed-by: default avatarVadim Fedorenko <vadim.fedorenko@linux.dev>
Link: https://patch.msgid.link/20241222-sysfs-const-bin_attr-ptp-v1-1-5c1f3ee246fb@weissschuh.net


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c83ca5a4

drivers/ptp/ptp_ocp.c

+8 −8
Original line number Diff line number Diff line
@@ -3692,7 +3692,7 @@ DEVICE_FREQ_GROUP(freq4, 3); 


static ssize_t

disciplining_config_read(struct file *filp, struct kobject *kobj,

			 struct bin_attribute *bin_attr, char *buf,

			 const struct bin_attribute *bin_attr, char *buf,

			 loff_t off, size_t count)

{

	struct ptp_ocp *bp = dev_get_drvdata(kobj_to_dev(kobj));
@@ -3727,7 +3727,7 @@ disciplining_config_read(struct file *filp, struct kobject *kobj, 


static ssize_t

disciplining_config_write(struct file *filp, struct kobject *kobj,

			  struct bin_attribute *bin_attr, char *buf,

			  const struct bin_attribute *bin_attr, char *buf,

			  loff_t off, size_t count)

{

	struct ptp_ocp *bp = dev_get_drvdata(kobj_to_dev(kobj));
@@ -3750,11 +3750,11 @@ disciplining_config_write(struct file *filp, struct kobject *kobj, 


	return err;

}

static BIN_ATTR_RW(disciplining_config, OCP_ART_CONFIG_SIZE);

static const BIN_ATTR_RW(disciplining_config, OCP_ART_CONFIG_SIZE);



static ssize_t

temperature_table_read(struct file *filp, struct kobject *kobj,

		       struct bin_attribute *bin_attr, char *buf,

		       const struct bin_attribute *bin_attr, char *buf,

		       loff_t off, size_t count)

{

	struct ptp_ocp *bp = dev_get_drvdata(kobj_to_dev(kobj));
@@ -3789,7 +3789,7 @@ temperature_table_read(struct file *filp, struct kobject *kobj, 


static ssize_t

temperature_table_write(struct file *filp, struct kobject *kobj,

			struct bin_attribute *bin_attr, char *buf,

			const struct bin_attribute *bin_attr, char *buf,

			loff_t off, size_t count)

{

	struct ptp_ocp *bp = dev_get_drvdata(kobj_to_dev(kobj));
@@ -3812,7 +3812,7 @@ temperature_table_write(struct file *filp, struct kobject *kobj, 


	return err;

}

static BIN_ATTR_RW(temperature_table, OCP_ART_TEMP_TABLE_SIZE);

static const BIN_ATTR_RW(temperature_table, OCP_ART_TEMP_TABLE_SIZE);



static struct attribute *fb_timecard_attrs[] = {

	&dev_attr_serialnum.attr,
@@ -3867,7 +3867,7 @@ static struct attribute *art_timecard_attrs[] = { 
	NULL,

};



static struct bin_attribute *bin_art_timecard_attrs[] = {

static const struct bin_attribute *const bin_art_timecard_attrs[] = {

	&bin_attr_disciplining_config,

	&bin_attr_temperature_table,

	NULL,
@@ -3875,7 +3875,7 @@ static struct bin_attribute *bin_art_timecard_attrs[] = { 


static const struct attribute_group art_timecard_group = {

	.attrs = art_timecard_attrs,

	.bin_attrs = bin_art_timecard_attrs,

	.bin_attrs_new = bin_art_timecard_attrs,

};



static const struct ocp_attr_group art_timecard_groups[] = {