Commit be382372 authored by Wentao Liang's avatar Wentao Liang Committed by Greg Kroah-Hartman
Browse files

greybus: gb-beagleplay: Add error handling for gb_greybus_init 



Add error handling for the gb_greybus_init(bg) function call
during the firmware reflash process to maintain consistency
in error handling throughout the codebase. If initialization
fails, log an error and return FW_UPLOAD_ERR_RW_ERROR.

Fixes: 0cf7befa ("greybus: gb-beagleplay: Add firmware upload API")
Signed-off-by: default avatarWentao Liang <vulab@iscas.ac.cn>
Reviewed-by: default avatarAyush Singh <ayush@beagleboard.org>
Link: https://lore.kernel.org/r/20250120140547.1460-1-vulab@iscas.ac.cn


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a64dcfb4

drivers/greybus/gb-beagleplay.c

+3 −1
Original line number Diff line number Diff line
@@ -912,7 +912,9 @@ static enum fw_upload_err cc1352_prepare(struct fw_upload *fw_upload, 
		cc1352_bootloader_reset(bg);

		WRITE_ONCE(bg->flashing_mode, false);

		msleep(200);

		gb_greybus_init(bg);

		if (gb_greybus_init(bg) < 0)

			return dev_err_probe(&bg->sd->dev, FW_UPLOAD_ERR_RW_ERROR,

					     "Failed to initialize greybus");

		gb_beagleplay_start_svc(bg);

		return FW_UPLOAD_ERR_FW_INVALID;

	}