Commit be411df6 authored Jan 17, 2009 by Andy Walls Committed by Mauro Carvalho Chehab Mar 30, 2009

V4L/DVB (10283): cx18: Call request_module() with proper argument types.



request_module() needs to be called with a string literal for a
format string or with 1 or more variable arguments to avoid
compiler warnings and possible exploits, if someone could cause
us to get a format string with a '%' code in the format string
when we make the call.

Reported-by: Brandon Jenkins <bcjenkins@tvwhere.com>
Signed-off-by: Andy Walls <awalls@radix.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent 888cdb07

drivers/media/video/cx18/cx18-driver.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -728,7 +728,7 @@ static u32 cx18_request_module(struct cx18 *cx, u32 hw,
		{
		if ((hw & id) == 0)
		return hw;
		if (request_module(name) != 0) {
		if (request_module("%s", name) != 0) {
		CX18_ERR("Failed to load module %s\n", name);
		return hw & ~id;
		}