Commit be6324a8 authored by Adarsh Das's avatar Adarsh Das Committed by David Sterba
Browse files

btrfs: replace BUG() with error handling in __btrfs_balance() 



We search with offset (u64)-1 which should never match exactly.
Previously this was handled with BUG(). Now logs an error
and return -EUCLEAN.

Reviewed-by: default avatarQu Wenruo <wqu@suse.com>
Signed-off-by: default avatarAdarsh Das <adarshdas950@gmail.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 1c88823a

fs/btrfs/volumes.c

+8 −2
Original line number Diff line number Diff line
@@ -4367,8 +4367,14 @@ static int __btrfs_balance(struct btrfs_fs_info *fs_info) 
		 * this shouldn't happen, it means the last relocate

		 * failed

		 */

		if (ret == 0)

			BUG(); /* FIXME break ? */

		if (unlikely(ret == 0)) {

			btrfs_err(fs_info,

				  "unexpected exact match of CHUNK_ITEM in chunk tree, offset 0x%llx",

				  key.offset);

			mutex_unlock(&fs_info->reclaim_bgs_lock);

			ret = -EUCLEAN;

			goto error;

		}



		ret = btrfs_previous_item(chunk_root, path, 0,

					  BTRFS_CHUNK_ITEM_KEY);