Commit be8058f3 authored by Tomas Glozar's avatar Tomas Glozar
Browse files

rtla: Fix segfault on multiple SIGINTs 



Detach stop_trace() from SIGINT/SIGALRM on tool clean-up to prevent it
from crashing RTLA by accessing freed memory.

This prevents a crash when multiple SIGINTs are received.

Fixes: d6899e56 ("rtla/timerlat_hist: Abort event processing on second signal")
Fixes: 80967b35 ("rtla/timerlat_top: Abort event processing on second signal")
Reviewed-by: default avatarWander Lairson Costa <wander@redhat.com>
Link: https://lore.kernel.org/r/20260310160725.144443-1-tglozar@redhat.com


Signed-off-by: default avatarTomas Glozar <tglozar@redhat.com>
parent 99261ccd

tools/tracing/rtla/src/common.c

+15 −1
Original line number Diff line number Diff line
@@ -41,6 +41,18 @@ static void set_signals(struct common_params *params) 
	}

}



/*

 * unset_signals - unsets the signals to stop the tool

 */

static void unset_signals(struct common_params *params)

{

	signal(SIGINT, SIG_DFL);

	if (params->duration) {

		alarm(0);

		signal(SIGALRM, SIG_DFL);

	}

}



/*

 * getopt_auto - auto-generates optstring from long_options

 */
@@ -351,7 +363,7 @@ int run_tool(struct tool_ops *ops, int argc, char *argv[]) 


	retval = ops->main(tool);

	if (retval)

		goto out_trace;

		goto out_signals;



	if (params->user_workload && !params->user.stopped_running) {

		params->user.should_run = 0;
@@ -373,6 +385,8 @@ int run_tool(struct tool_ops *ops, int argc, char *argv[]) 
	if (ops->analyze)

		ops->analyze(tool, stopped);



out_signals:

	unset_signals(params);

out_trace:

	trace_events_destroy(&tool->record->trace, params->events);

	params->events = NULL;