Commit be96d894 authored by Tudor Ambarus's avatar Tudor Ambarus Committed by Greg Kroah-Hartman
Browse files

tty: serial: samsung: return bool for s3c24xx_serial_console_txrdy() 



s3c24xx_serial_console_txrdy() returned just 0 or 1 to indicate whether
the TX is empty or not. Change its return type to bool.

Reviewed-by: default avatarSam Protsenko <semen.protsenko@linaro.org>
Signed-off-by: default avatarTudor Ambarus <tudor.ambarus@linaro.org>
Link: https://lore.kernel.org/r/20240119104526.1221243-16-tudor.ambarus@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f09e8da6

drivers/tty/serial/samsung_tty.c

+3 −3
Original line number Diff line number Diff line
@@ -2184,7 +2184,7 @@ static const struct dev_pm_ops s3c24xx_serial_pm_ops = { 


static struct uart_port *cons_uart;



static int

static bool

s3c24xx_serial_console_txrdy(struct uart_port *port, u32 ufcon)

{

	const struct s3c24xx_uart_info *info = s3c24xx_port_to_info(port);
@@ -2194,13 +2194,13 @@ s3c24xx_serial_console_txrdy(struct uart_port *port, u32 ufcon) 
		/* fifo mode - check amount of data in fifo registers... */



		ufstat = rd_regl(port, S3C2410_UFSTAT);

		return (ufstat & info->tx_fifofull) ? 0 : 1;

		return !(ufstat & info->tx_fifofull);

	}



	/* in non-fifo mode, we go and use the tx buffer empty */



	utrstat = rd_regl(port, S3C2410_UTRSTAT);

	return (utrstat & S3C2410_UTRSTAT_TXE) ? 1 : 0;

	return utrstat & S3C2410_UTRSTAT_TXE;

}



static bool