Commit be9edde4 authored by Lukas Wunner's avatar Lukas Wunner Committed by Bjorn Helgaas
Browse files

PCI/PM: Stop needlessly clearing state_saved on enumeration and thaw 



The state_saved flag tells the PCI core whether a driver assumes
responsibility to save Config Space and put the device into a low power
state on suspend.

The flag is currently initialized to false on enumeration, even though it
already is false (because struct pci_dev is zeroed by kzalloc()) and even
though it is set to false before commencing the suspend sequence (the only
code path where it's relevant).

The flag is also set to false in pci_pm_thaw(), i.e. on resume, when it's
no longer relevant.

Drop these two superfluous flag assignments for simplicity.

Signed-off-by: default avatarLukas Wunner <lukas@wunner.de>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarRafael J. Wysocki (Intel) <rafael@kernel.org>
Link: https://patch.msgid.link/fd167945bd7852e1ca08cd4b202130659eea2c2f.1763483367.git.lukas@wunner.de
parent 894f475f

drivers/pci/pci-driver.c

+0 −2
Original line number Diff line number Diff line
@@ -1133,8 +1133,6 @@ static int pci_pm_thaw(struct device *dev) 
		pci_pm_reenable_device(pci_dev);

	}



	pci_dev->state_saved = false;



	return error;

}

drivers/pci/probe.c

+0 −2
Original line number Diff line number Diff line
@@ -2747,8 +2747,6 @@ void pci_device_add(struct pci_dev *dev, struct pci_bus *bus) 


	pci_reassigndev_resource_alignment(dev);



	dev->state_saved = false;



	pci_init_capabilities(dev);



	/*