Commit bea3e7bf authored by Tiffany Yang's avatar Tiffany Yang Committed by Greg Kroah-Hartman
Browse files

binder: Fix selftest page indexing 



The binder allocator selftest was only checking the last page of buffers
that ended on a page boundary. Correct the page indexing to account for
buffers that are not page-aligned.

Signed-off-by: default avatarTiffany Yang <ynaffit@google.com>
Acked-by: default avatarCarlos Llamas <cmllamas@google.com>
Link: https://lore.kernel.org/r/20250714185321.2417234-2-ynaffit@google.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 01afddca

drivers/android/binder_alloc_selftest.c

+1 −1
Original line number Diff line number Diff line
@@ -142,12 +142,12 @@ static void binder_selftest_free_buf(struct binder_alloc *alloc, 
	for (i = 0; i < BUFFER_NUM; i++)

		binder_alloc_free_buf(alloc, buffers[seq[i]]);



	for (i = 0; i < end / PAGE_SIZE; i++) {

		/**

		 * Error message on a free page can be false positive

		 * if binder shrinker ran during binder_alloc_free_buf

		 * calls above.

		 */

	for (i = 0; i <= (end - 1) / PAGE_SIZE; i++) {

		if (list_empty(page_to_lru(alloc->pages[i]))) {

			pr_err_size_seq(sizes, seq);

			pr_err("expect lru but is %s at page index %d\n",