Commit bedb2ccb authored by Vasileios Amoiridis's avatar Vasileios Amoiridis Committed by Jonathan Cameron
Browse files

iio: imu: bmi323: Fix trigger notification in case of error 



In case of error in the bmi323_trigger_handler() function, the
function exits without calling the iio_trigger_notify_done()
which is responsible for informing the attached trigger that
the process is done and in case there is a .reenable(), to
call it.

Fixes: 8a636db3 ("iio: imu: Add driver for BMI323 IMU")
Signed-off-by: default avatarVasileios Amoiridis <vassilisamir@gmail.com>
Link: https://lore.kernel.org/r/20240508155407.139805-1-vassilisamir@gmail.com


Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 279428df

drivers/iio/imu/bmi323/bmi323_core.c

+3 −2
Original line number Diff line number Diff line
@@ -1391,7 +1391,7 @@ static irqreturn_t bmi323_trigger_handler(int irq, void *p) 
				       &data->buffer.channels,

				       ARRAY_SIZE(data->buffer.channels));

		if (ret)

			return IRQ_NONE;

			goto out;

	} else {

		for_each_set_bit(bit, indio_dev->active_scan_mask,

				 BMI323_CHAN_MAX) {
@@ -1400,13 +1400,14 @@ static irqreturn_t bmi323_trigger_handler(int irq, void *p) 
					      &data->buffer.channels[index++],

					      BMI323_BYTES_PER_SAMPLE);

			if (ret)

				return IRQ_NONE;

				goto out;

		}

	}



	iio_push_to_buffers_with_timestamp(indio_dev, &data->buffer,

					   iio_get_time_ns(indio_dev));



out:

	iio_trigger_notify_done(indio_dev->trig);



	return IRQ_HANDLED;