Commit bedf9236 authored by Masahiro Yamada's avatar Masahiro Yamada
Browse files

kconfig: use linked list in get_symbol_str() to iterate over menus 



Currently, get_symbol_str() uses a tricky approach to traverse the
associated menus.

With relevant menus now linked to the symbol using a linked list,
use list_for_each_entry() for iterating on the menus.

Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
Reviewed-by: default avatarNicolas Schier <nicolas@fjasle.eu>
parent e0492219

scripts/kconfig/menu.c

+9 −8
Original line number Diff line number Diff line
@@ -771,6 +771,7 @@ static void get_symbol_str(struct gstr *r, struct symbol *sym, 
		    struct list_head *head)

{

	struct property *prop;

	struct menu *menu;



	if (sym && sym->name) {

		str_printf(r, "Symbol: %s [=%s]\n", sym->name,
@@ -787,17 +788,17 @@ static void get_symbol_str(struct gstr *r, struct symbol *sym, 
	}



	/* Print the definitions with prompts before the ones without */

	for_all_properties(sym, prop, P_SYMBOL) {

		if (prop->menu->prompt) {

			get_def_str(r, prop->menu);

			get_prompt_str(r, prop->menu->prompt, head);

	list_for_each_entry(menu, &sym->menus, link) {

		if (menu->prompt) {

			get_def_str(r, menu);

			get_prompt_str(r, menu->prompt, head);

		}

	}



	for_all_properties(sym, prop, P_SYMBOL) {

		if (!prop->menu->prompt) {

			get_def_str(r, prop->menu);

			get_dep_str(r, prop->menu->dep, "  Depends on: ");

	list_for_each_entry(menu, &sym->menus, link) {

		if (!menu->prompt) {

			get_def_str(r, menu);

			get_dep_str(r, menu->dep, "  Depends on: ");

		}

	}