Commit bf069012 authored by Hao Ge's avatar Hao Ge Committed by Andrew Morton
Browse files

selftests/mm/cow: modify the incorrect checking parameters 

In run_with_memfd_hugetlb(), some error handle have passed incorrect
parameters.  It should be "smem", but it was mistakenly written as "mem".

Let's fix it.

[gehao@kylinos.cn: fix other errant sites, per Anshuman]
  Link: https://lkml.kernel.org/r/20250113050908.93638-1-hao.ge@linux.dev
Link: https://lkml.kernel.org/r/20250113032858.63670-1-hao.ge@linux.dev


Fixes: f8664f3c ("selftests/vm: cow: basic COW tests for non-anonymous pages")
Signed-off-by: default avatarHao Ge <gehao@kylinos.cn>
Cc: SeongJae Park <sj@kernel.org>
Cc: Shuah Khan (Samsung OSG) <shuah@kernel.org>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent d6550ee4

tools/testing/selftests/mm/cow.c

+5 −5
Original line number Diff line number Diff line
@@ -1482,7 +1482,7 @@ static void run_with_zeropage(non_anon_test_fn fn, const char *desc) 
	}



	smem = mmap(NULL, pagesize, PROT_READ, MAP_PRIVATE | MAP_ANON, -1, 0);

	if (mem == MAP_FAILED) {

	if (smem == MAP_FAILED) {

		ksft_test_result_fail("mmap() failed\n");

		goto munmap;

	}
@@ -1583,7 +1583,7 @@ static void run_with_memfd(non_anon_test_fn fn, const char *desc) 
		goto close;

	}

	smem = mmap(NULL, pagesize, PROT_READ, MAP_SHARED, fd, 0);

	if (mem == MAP_FAILED) {

	if (smem == MAP_FAILED) {

		ksft_test_result_fail("mmap() failed\n");

		goto munmap;

	}
@@ -1634,7 +1634,7 @@ static void run_with_tmpfile(non_anon_test_fn fn, const char *desc) 
		goto close;

	}

	smem = mmap(NULL, pagesize, PROT_READ, MAP_SHARED, fd, 0);

	if (mem == MAP_FAILED) {

	if (smem == MAP_FAILED) {

		ksft_test_result_fail("mmap() failed\n");

		goto munmap;

	}
@@ -1684,7 +1684,7 @@ static void run_with_memfd_hugetlb(non_anon_test_fn fn, const char *desc, 
		goto close;

	}

	smem = mmap(NULL, hugetlbsize, PROT_READ, MAP_SHARED, fd, 0);

	if (mem == MAP_FAILED) {

	if (smem == MAP_FAILED) {

		ksft_test_result_fail("mmap() failed\n");

		goto munmap;

	}
@@ -1696,7 +1696,7 @@ static void run_with_memfd_hugetlb(non_anon_test_fn fn, const char *desc, 
	fn(mem, smem, hugetlbsize);

munmap:

	munmap(mem, hugetlbsize);

	if (mem != MAP_FAILED)

	if (smem != MAP_FAILED)

		munmap(smem, hugetlbsize);

close:

	close(fd);