Commit bf237a9f authored by Yongxing Mou's avatar Yongxing Mou Committed by Vinod Koul
Browse files

phy: qcom: edp: Fix AUX_CFG8 programming for DP mode 



AUX_CFG8 depends on whether the PHY is operating in eDP or DP mode, not
the selected swing/pre-emphasis table. All supported platforms already
have the proper tables, so remove the unnecessary check.

Cc: stable@vger.kernel.org
Fixes: 6078b8ce ("phy: qcom: edp: Add set_mode op for configuring eDP/DP submode")
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: default avatarYongxing Mou <yongxing.mou@oss.qualcomm.com>
Link: https://patch.msgid.link/20260427-edp_phy-v5-4-3bb876824475@oss.qualcomm.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 3d22594d

drivers/phy/qualcomm/phy-qcom-edp.c

+1 −6
Original line number Diff line number Diff line
@@ -325,12 +325,7 @@ static int qcom_edp_phy_init(struct phy *phy) 
	       DP_PHY_PD_CTL_PLL_PWRDN | DP_PHY_PD_CTL_DP_CLAMP_EN,

	       edp->edp + DP_PHY_PD_CTL);



	/*

	 * TODO: Re-work the conditions around setting the cfg8 value

	 * when more information becomes available about why this is

	 * even needed.

	 */

	if (edp->cfg->dp_swing_pre_emph_cfg && !edp->is_edp)

	if (!edp->is_edp)

		aux_cfg[8] = 0xb7;



	writel(0xfc, edp->edp + DP_PHY_MODE);