Commit bf2d0d88 authored by Michał Winiarski's avatar Michał Winiarski Committed by Rodrigo Vivi
Browse files

drm/xe/uc: Store firmware binary in system-memory backed BO 



The firmware loading for GuC is about to be moved, and will happen much
earlier in the probe process, when local-memory is not yet available.
While this has the potential to make the firmware loading process
slower, this is only happening during probe and full device reset.
Since both are not hot-paths - store all UC-like firmware in system
memory.

Signed-off-by: default avatarMichał Winiarski <michal.winiarski@intel.com>
Reviewed-by: default avatarMatt Roper <matthew.d.roper@intel.com>
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent c93ea051

drivers/gpu/drm/xe/xe_uc_fw.c

+1 −3
Original line number Diff line number Diff line
@@ -750,8 +750,6 @@ static int uc_fw_copy(struct xe_uc_fw *uc_fw, const void *data, size_t size, u32 
int xe_uc_fw_init(struct xe_uc_fw *uc_fw)

{

	const struct firmware *fw = NULL;

	struct xe_gt *gt = uc_fw_to_gt(uc_fw);

	struct xe_tile *tile = gt_to_tile(gt);

	int err;



	err = uc_fw_request(uc_fw, &fw);
@@ -763,7 +761,7 @@ int xe_uc_fw_init(struct xe_uc_fw *uc_fw) 
		return 0;



	err = uc_fw_copy(uc_fw, fw->data, fw->size,

			 XE_BO_CREATE_VRAM_IF_DGFX(tile) | XE_BO_CREATE_GGTT_BIT);

			 XE_BO_CREATE_SYSTEM_BIT | XE_BO_CREATE_GGTT_BIT);



	uc_fw_release(fw);