Unverified Commit bf2d764b authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: SOF: Intel: hda-codec: add stop_cmd_io helper 



One more helper to split controller and codec

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarRander Wang <rander.wang@intel.com>
Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarPéter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/20221027193540.259520-11-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent d4bfba1e

sound/soc/sof/intel/hda-codec.c

+9 −0
Original line number Diff line number Diff line
@@ -269,6 +269,15 @@ void hda_codec_init_cmd_io(struct snd_sof_dev *sdev) 
}

EXPORT_SYMBOL_NS_GPL(hda_codec_init_cmd_io, SND_SOC_SOF_HDA_AUDIO_CODEC);



void hda_codec_stop_cmd_io(struct snd_sof_dev *sdev)

{

	struct hdac_bus *bus = sof_to_bus(sdev);



	/* initialize the codec command I/O */

	snd_hdac_bus_stop_cmd_io(bus);

}

EXPORT_SYMBOL_NS_GPL(hda_codec_stop_cmd_io, SND_SOC_SOF_HDA_AUDIO_CODEC);



void hda_codec_rirb_status_clear(struct snd_sof_dev *sdev)

{

	struct hdac_bus *bus = sof_to_bus(sdev);

sound/soc/sof/intel/hda-ctrl.c

+2 −4
Original line number Diff line number Diff line
@@ -299,10 +299,8 @@ void hda_dsp_ctrl_stop_chip(struct snd_sof_dev *sdev) 
	snd_sof_dsp_write(sdev, HDA_DSP_HDA_BAR, SOF_HDA_INTSTS,

			  SOF_HDA_INT_CTRL_EN | SOF_HDA_INT_ALL_STREAM);



#if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA)

	/* disable CORB/RIRB */

	snd_hdac_bus_stop_cmd_io(bus);

#endif

	hda_codec_stop_cmd_io(sdev);



	/* disable position buffer */

	if (bus->use_posbuf && bus->posbuf.addr) {

		snd_sof_dsp_write(sdev, HDA_DSP_HDA_BAR,

sound/soc/sof/intel/hda.h

+2 −0
Original line number Diff line number Diff line
@@ -719,6 +719,7 @@ void hda_codec_jack_wake_enable(struct snd_sof_dev *sdev, bool enable); 
void hda_codec_jack_check(struct snd_sof_dev *sdev);

void hda_codec_check_for_state_change(struct snd_sof_dev *sdev);

void hda_codec_init_cmd_io(struct snd_sof_dev *sdev);

void hda_codec_stop_cmd_io(struct snd_sof_dev *sdev);

void hda_codec_detect_mask(struct snd_sof_dev *sdev);

void hda_codec_rirb_status_clear(struct snd_sof_dev *sdev);

void hda_codec_set_codec_wakeup(struct snd_sof_dev *sdev, bool status);
@@ -731,6 +732,7 @@ static inline void hda_codec_jack_wake_enable(struct snd_sof_dev *sdev, bool ena 
static inline void hda_codec_jack_check(struct snd_sof_dev *sdev) { }

static inline void hda_codec_check_for_state_change(struct snd_sof_dev *sdev) { }

static inline void hda_codec_init_cmd_io(struct snd_sof_dev *sdev) { }

static inline void hda_codec_stop_cmd_io(struct snd_sof_dev *sdev) { }

static inline void hda_codec_detect_mask(struct snd_sof_dev *sdev) { }

static inline void hda_codec_rirb_status_clear(struct snd_sof_dev *sdev) { }

static inline void hda_codec_set_codec_wakeup(struct snd_sof_dev *sdev, bool status) { }