Commit bf32bcee authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Dmitry Torokhov
Browse files

Input: ims-pcu - fix printf string overflow 



clang warns about a string overflow in this driver

drivers/input/misc/ims-pcu.c:1802:2: error: 'snprintf' will always be truncated; specified size is 10, but format string expands to at least 12 [-Werror,-Wformat-truncation]
drivers/input/misc/ims-pcu.c:1814:2: error: 'snprintf' will always be truncated; specified size is 10, but format string expands to at least 12 [-Werror,-Wformat-truncation]

Make the buffer a little longer to ensure it always fits.

Fixes: 628329d5 ("Input: add IMS Passenger Control Unit driver")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20240326223825.4084412-7-arnd@kernel.org


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent c7df39b2

drivers/input/misc/ims-pcu.c

+2 −2
Original line number Diff line number Diff line
@@ -42,8 +42,8 @@ struct ims_pcu_backlight { 
#define IMS_PCU_PART_NUMBER_LEN		15

#define IMS_PCU_SERIAL_NUMBER_LEN	8

#define IMS_PCU_DOM_LEN			8

#define IMS_PCU_FW_VERSION_LEN		(9 + 1)

#define IMS_PCU_BL_VERSION_LEN		(9 + 1)

#define IMS_PCU_FW_VERSION_LEN		16

#define IMS_PCU_BL_VERSION_LEN		16

#define IMS_PCU_BL_RESET_REASON_LEN	(2 + 1)



#define IMS_PCU_PCU_B_DEVICE_ID		5