Commit bf67e693 authored by Damien Le Moal's avatar Damien Le Moal Committed by Martin K. Petersen
Browse files

scsi: pm8001: Simplify pm8001_get_ncq_tag() 

To detect if a command is NCQ, there is no need to test all possible NCQ
command codes. Instead, use ata_is_ncq() to test the command protocol.

Link: https://lore.kernel.org/r/20220220031810.738362-26-damien.lemoal@opensource.wdc.com


Reviewed-by: default avatarJohn Garry <john.garry@huawei.com>
Reviewed-by: default avatarJack Wang <jinpu.wang@ionos.com>
Signed-off-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 0c4ad6c3

drivers/scsi/pm8001/pm8001_sas.c

+5 −9
Original line number Diff line number Diff line
@@ -304,16 +304,12 @@ static int pm8001_task_prep_smp(struct pm8001_hba_info *pm8001_ha, 
u32 pm8001_get_ncq_tag(struct sas_task *task, u32 *tag)

{

	struct ata_queued_cmd *qc = task->uldd_task;

	if (qc) {

		if (qc->tf.command == ATA_CMD_FPDMA_WRITE ||

		    qc->tf.command == ATA_CMD_FPDMA_READ ||

		    qc->tf.command == ATA_CMD_FPDMA_RECV ||

		    qc->tf.command == ATA_CMD_FPDMA_SEND ||

		    qc->tf.command == ATA_CMD_NCQ_NON_DATA) {



	if (qc && ata_is_ncq(qc->tf.protocol)) {

		*tag = qc->tag;

		return 1;

	}

	}



	return 0;

}