Commit bfa0f02d authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Lee Jones
Browse files

leds: qcom-lpg: Add QCOM_PBS dependency 



The lpg driver fails to link now when the pbs driver is in a loadable module:

x86_64-linux-ld: drivers/leds/rgb/leds-qcom-lpg.o: in function `lpg_brightness_set':
leds-qcom-lpg.c:(.text+0xe7f): undefined reference to `qcom_pbs_trigger_event'
x86_64-linux-ld: drivers/leds/rgb/leds-qcom-lpg.o: in function `lpg_probe':
leds-qcom-lpg.c:(.text+0x16a5): undefined reference to `get_pbs_client_device'

Add a dependency to avoid the broken configuration. Apparently there is still
a use for lpg with pbs disabled entirely for certain chips, so allow both
but not LEDS_QCOM_LPG=y with QCOM_PBS=m.

Fixes: 214110175679 ("leds: rgb: leds-qcom-lpg: Add support for PPG through single SDAM")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarJean Delvare <jdelvare@suse.de>
Link: https://lore.kernel.org/r/20240212111526.829122-1-arnd@kernel.org


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent ec9aa897

drivers/leds/rgb/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -41,6 +41,7 @@ config LEDS_QCOM_LPG 
	tristate "LED support for Qualcomm LPG"

	depends on OF

	depends on PWM

	depends on QCOM_PBS || !QCOM_PBS

	depends on SPMI

	help

	  This option enables support for the Light Pulse Generator found in a