Commit bfa54a79 authored by Zijun Hu's avatar Zijun Hu Committed by Greg Kroah-Hartman
Browse files

driver core: bus: Fix double free in driver API bus_register() 



For bus_register(), any error which happens after kset_register() will
cause that @priv are freed twice, fixed by setting @priv with NULL after
the first free.

Signed-off-by: default avatarZijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20240727-bus_register_fix-v1-1-fed8dd0dba7a@quicinc.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2bdf3b83

drivers/base/bus.c

+2 −0
Original line number Diff line number Diff line
@@ -922,6 +922,8 @@ int bus_register(const struct bus_type *bus) 
	bus_remove_file(bus, &bus_attr_uevent);

bus_uevent_fail:

	kset_unregister(&priv->subsys);

	/* Above kset_unregister() will kfree @priv */

	priv = NULL;

out:

	kfree(priv);

	return retval;