Commit bfb1ad3c authored by Takashi Sakamoto's avatar Takashi Sakamoto
Browse files

firewire: core: add memo about the caller of show functions for device attributes 

In the case of firewire core function, the caller of show functions for
device attributes is not only sysfs user, but also device initialization.

This commit adds memo about it against the typical assumption that the
functions are just dedicated to sysfs user.

Link: https://lore.kernel.org/lkml/20240318091759.678326-1-o-takashi@sakamocchi.jp/


Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
parent 946593d1

drivers/firewire/core-device.c

+2 −0
Original line number Diff line number Diff line
@@ -322,6 +322,7 @@ static ssize_t show_immediate(struct device *dev, 
	if (value < 0)

		return -ENOENT;



	// Note that this function is also called by init_fw_attribute_group() with NULL pointer.

	return buf ? sysfs_emit(buf, "0x%06x\n", value) : 0;

}
@@ -357,6 +358,7 @@ static ssize_t show_text_leaf(struct device *dev, 
		}

	}



	// Note that this function is also called by init_fw_attribute_group() with NULL pointer.

	if (buf) {

		bufsize = PAGE_SIZE - 1;

	} else {