Commit bfc0ed73 authored by Emmanuel Grumbach's avatar Emmanuel Grumbach Committed by Johannes Berg
Browse files

Revert "wifi: iwlwifi: remove retry loops in start" 



Revert commit dfdfe4be ("wifi: iwlwifi: remove retry loops in
start"), it turns out that there's an issue with the PNVM load
notification from firmware not getting processed, that this patch
has been somewhat successfully papering over. Since this is being
reported, revert the loop removal for now.

We will later at least clean this up to only attempt to retry if
there was a timeout, but currently we don't even bubble up the
failure reason to the correct layer, only returning NULL.

Fixes: dfdfe4be ("wifi: iwlwifi: remove retry loops in start")
Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Link: https://patch.msgid.link/20241022092212.4aa82a558a00.Ibdeff9c8f0d608bc97fc42024392ae763b6937b7@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 734a377e

drivers/net/wireless/intel/iwlwifi/iwl-drv.c

+19 −9
Original line number Diff line number Diff line
@@ -1413,10 +1413,13 @@ _iwl_op_mode_start(struct iwl_drv *drv, struct iwlwifi_opmode_table *op) 
	const struct iwl_op_mode_ops *ops = op->ops;

	struct dentry *dbgfs_dir = NULL;

	struct iwl_op_mode *op_mode = NULL;

	int retry, max_retry = !!iwlwifi_mod_params.fw_restart * IWL_MAX_INIT_RETRY;



	/* also protects start/stop from racing against each other */

	lockdep_assert_held(&iwlwifi_opmode_table_mtx);



	for (retry = 0; retry <= max_retry; retry++) {



#ifdef CONFIG_IWLWIFI_DEBUGFS

		drv->dbgfs_op_mode = debugfs_create_dir(op->name,

							drv->dbgfs_drv);
@@ -1425,13 +1428,20 @@ _iwl_op_mode_start(struct iwl_drv *drv, struct iwlwifi_opmode_table *op) 


		op_mode = ops->start(drv->trans, drv->trans->cfg,

				     &drv->fw, dbgfs_dir);



		if (op_mode)

			return op_mode;



		if (test_bit(STATUS_TRANS_DEAD, &drv->trans->status))

			break;



		IWL_ERR(drv, "retry init count %d\n", retry);



#ifdef CONFIG_IWLWIFI_DEBUGFS

		debugfs_remove_recursive(drv->dbgfs_op_mode);

		drv->dbgfs_op_mode = NULL;

#endif

	}



	return NULL;

}

drivers/net/wireless/intel/iwlwifi/iwl-drv.h

+3 −0
Original line number Diff line number Diff line
@@ -98,6 +98,9 @@ void iwl_drv_stop(struct iwl_drv *drv); 
#define VISIBLE_IF_IWLWIFI_KUNIT static

#endif



/* max retry for init flow */

#define IWL_MAX_INIT_RETRY 2



#define FW_NAME_PRE_BUFSIZE	64

struct iwl_trans;

const char *iwl_drv_get_fwname_pre(struct iwl_trans *trans, char *buf);

drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c

+9 −1
Original line number Diff line number Diff line
@@ -1293,12 +1293,14 @@ int iwl_mvm_mac_start(struct ieee80211_hw *hw) 
{

	struct iwl_mvm *mvm = IWL_MAC80211_GET_MVM(hw);

	int ret;

	int retry, max_retry = 0;



	mutex_lock(&mvm->mutex);



	/* we are starting the mac not in error flow, and restart is enabled */

	if (!test_bit(IWL_MVM_STATUS_HW_RESTART_REQUESTED, &mvm->status) &&

	    iwlwifi_mod_params.fw_restart) {

		max_retry = IWL_MAX_INIT_RETRY;

		/*

		 * This will prevent mac80211 recovery flows to trigger during

		 * init failures
@@ -1306,7 +1308,13 @@ int iwl_mvm_mac_start(struct ieee80211_hw *hw) 
		set_bit(IWL_MVM_STATUS_STARTING, &mvm->status);

	}



	for (retry = 0; retry <= max_retry; retry++) {

		ret = __iwl_mvm_mac_start(mvm);

		if (!ret)

			break;



		IWL_ERR(mvm, "mac start retry %d\n", retry);

	}

	clear_bit(IWL_MVM_STATUS_STARTING, &mvm->status);



	mutex_unlock(&mvm->mutex);