Commit bfccbaac authored by Stanislav Fomichev's avatar Stanislav Fomichev Committed by Jakub Kicinski
Browse files

selftests: ncdevmem: Unify error handling 



There is a bunch of places where error() calls look out of place.
Use the same error(1, errno, ...) pattern everywhere.

Reviewed-by: default avatarMina Almasry <almasrymina@google.com>
Reviewed-by: default avatarJoe Damato <jdamato@fastly.com>
Signed-off-by: default avatarStanislav Fomichev <sdf@fomichev.me>
Link: https://patch.msgid.link/20241107181211.3934153-4-sdf@fomichev.me


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8b9049af

tools/testing/selftests/net/ncdevmem.c

+8 −8
Original line number Diff line number Diff line
@@ -339,33 +339,33 @@ int do_server(struct memory_buffer *mem) 
	server_sin.sin_port = htons(atoi(port));



	ret = inet_pton(server_sin.sin_family, server_ip, &server_sin.sin_addr);

	if (socket < 0)

		error(79, 0, "%s: [FAIL, create socket]\n", TEST_PREFIX);

	if (ret < 0)

		error(1, errno, "%s: [FAIL, create socket]\n", TEST_PREFIX);



	socket_fd = socket(server_sin.sin_family, SOCK_STREAM, 0);

	if (socket < 0)

		error(errno, errno, "%s: [FAIL, create socket]\n", TEST_PREFIX);

	if (socket_fd < 0)

		error(1, errno, "%s: [FAIL, create socket]\n", TEST_PREFIX);



	ret = setsockopt(socket_fd, SOL_SOCKET, SO_REUSEPORT, &opt,

			 sizeof(opt));

	if (ret)

		error(errno, errno, "%s: [FAIL, set sock opt]\n", TEST_PREFIX);

		error(1, errno, "%s: [FAIL, set sock opt]\n", TEST_PREFIX);



	ret = setsockopt(socket_fd, SOL_SOCKET, SO_REUSEADDR, &opt,

			 sizeof(opt));

	if (ret)

		error(errno, errno, "%s: [FAIL, set sock opt]\n", TEST_PREFIX);

		error(1, errno, "%s: [FAIL, set sock opt]\n", TEST_PREFIX);



	fprintf(stderr, "binding to address %s:%d\n", server_ip,

		ntohs(server_sin.sin_port));



	ret = bind(socket_fd, &server_sin, sizeof(server_sin));

	if (ret)

		error(errno, errno, "%s: [FAIL, bind]\n", TEST_PREFIX);

		error(1, errno, "%s: [FAIL, bind]\n", TEST_PREFIX);



	ret = listen(socket_fd, 1);

	if (ret)

		error(errno, errno, "%s: [FAIL, listen]\n", TEST_PREFIX);

		error(1, errno, "%s: [FAIL, listen]\n", TEST_PREFIX);



	client_addr_len = sizeof(client_addr);