Commit bfcd1fda authored by Dan Carpenter's avatar Dan Carpenter Committed by Thomas Gleixner
Browse files

irqchip/gic-v5: Fix loop in gicv5_its_create_itt_two_level() cleanup path 



The "i" variable in gicv5_its_create_itt_two_level() needs to be signed
otherwise it can cause a forever loop in the function's cleanup path.

[ lpieralisi: Reworded commit message ]

Fixes: 57d72196 ("irqchip/gic-v5: Add GICv5 ITS support")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarLorenzo Pieralisi <lpieralisi@kernel.org>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarZenghui Yu <yuzenghui@huawei.com>
Link: https://lore.kernel.org/all/20250908082745.113718-3-lpieralisi@kernel.org
parent 5a5c48e8

drivers/irqchip/irq-gic-v5-its.c

+2 −2
Original line number Diff line number Diff line
@@ -191,9 +191,9 @@ static int gicv5_its_create_itt_two_level(struct gicv5_its_chip_data *its, 
					  unsigned int num_events)

{

	unsigned int l1_bits, l2_bits, span, events_per_l2_table;

	unsigned int i, complete_tables, final_span, num_ents;

	unsigned int complete_tables, final_span, num_ents;

	__le64 *itt_l1, *itt_l2, **l2ptrs;

	int ret;

	int i, ret;

	u64 val;



	ret = gicv5_its_l2sz_to_l2_bits(itt_l2sz);