Commit bfe4ab93 authored by Yury Norov's avatar Yury Norov Committed by Thomas Bogendoerfer
Browse files

MIPS: SGI-IP27: use WARN_ON() output 



WARN_ON() propagates the result of conditional expression, and it can be
used to return early in the following expression in the arch_init_irq().

This is a no-op cleanup, except that compiler may optimize the error paths
better because WARN_ON() implies 'unlikely()'.

Signed-off-by: default avatarYury Norov <yury.norov@gmail.com>
Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
parent 156e6498

arch/mips/sgi-ip27/ip27-irq.c

+3 −4
Original line number Diff line number Diff line
@@ -289,13 +289,12 @@ void __init arch_init_irq(void) 
	bitmap_set(hub_irq_map, NI_BRDCAST_ERR_A, MSC_PANIC_INTR - NI_BRDCAST_ERR_A + 1);



	fn = irq_domain_alloc_named_fwnode("HUB");

	WARN_ON(fn == NULL);

	if (!fn)

	if (WARN_ON(fn == NULL))

		return;



	domain = irq_domain_create_linear(fn, IP27_HUB_IRQ_COUNT,

					  &hub_domain_ops, NULL);

	WARN_ON(domain == NULL);

	if (!domain)

	if (WARN_ON(domain == NULL))

		return;



	irq_set_default_host(domain);