Commit bff13b8f authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

media/ivtvfb: Initialize fb_ops to fbdev I/O-memory helpers 



Initialize the instance of struct fb_ops with fbdev initializer
macros for framebuffers in I/O address space. This explictily sets
the read/write, draw and mmap callbacks to the correct default
implementation.

Fbdev drivers sometimes rely on the callbacks being NULL for a
default implementation to be invoked; hence requireing the I/O
helpers to be built in any case. Setting all callbacks in all
drivers explicitly will allow to make the I/O helpers optional.
This benefits systems that do not use these functions.

Set the callbacks via macros. No functional changes.

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Cc: Andy Walls <awalls@md.metrocast.net>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org
Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Reviewed-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Link: https://patchwork.freedesktop.org/patch/msgid/20231127131655.4020-21-tzimmermann@suse.de
parent 741effea

drivers/media/pci/ivtv/Kconfig

+1 −3
Original line number Diff line number Diff line
@@ -48,9 +48,7 @@ config VIDEO_IVTV_ALSA 
config VIDEO_FB_IVTV

	tristate "Conexant cx23415 framebuffer support"

	depends on VIDEO_IVTV && FB

	select FB_CFB_FILLRECT

	select FB_CFB_COPYAREA

	select FB_CFB_IMAGEBLIT

	select FB_IOMEM_HELPERS

	help

	  This is a framebuffer driver for the Conexant cx23415 MPEG

	  encoder/decoder.

drivers/media/pci/ivtv/ivtvfb.c

+3 −3
Original line number Diff line number Diff line
@@ -927,17 +927,17 @@ static int ivtvfb_blank(int blank_mode, struct fb_info *info) 


static const struct fb_ops ivtvfb_ops = {

	.owner = THIS_MODULE,

	.fb_read        = fb_io_read,

	.fb_write       = ivtvfb_write,

	.fb_check_var   = ivtvfb_check_var,

	.fb_set_par     = ivtvfb_set_par,

	.fb_setcolreg   = ivtvfb_setcolreg,

	.fb_fillrect    = cfb_fillrect,

	.fb_copyarea    = cfb_copyarea,

	.fb_imageblit   = cfb_imageblit,

	__FB_DEFAULT_IOMEM_OPS_DRAW,

	.fb_cursor      = NULL,

	.fb_ioctl       = ivtvfb_ioctl,

	.fb_pan_display = ivtvfb_pan_display,

	.fb_blank       = ivtvfb_blank,

	__FB_DEFAULT_IOMEM_OPS_MMAP,

};



/* Restore hardware after firmware restart */