Commit c0277b9d authored by Tim Huang's avatar Tim Huang Committed by Alex Deucher
Browse files

drm/amdgpu: fix unchecked return value warning for amdgpu_gfx 



This resolves the unchecded return value warning reported by Coverity.

Signed-off-by: default avatarTim Huang <tim.huang@amd.com>
Reviewed-by: default avatarJesse Zhang <jesse.zhang@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 57b09a16

drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c

+14 −4
Original line number Diff line number Diff line
@@ -860,8 +860,11 @@ int amdgpu_gfx_ras_late_init(struct amdgpu_device *adev, struct ras_common_if *r 
	int r;



	if (amdgpu_ras_is_supported(adev, ras_block->block)) {

		if (!amdgpu_persistent_edc_harvesting_supported(adev))

			amdgpu_ras_reset_error_status(adev, AMDGPU_RAS_BLOCK__GFX);

		if (!amdgpu_persistent_edc_harvesting_supported(adev)) {

			r = amdgpu_ras_reset_error_status(adev, AMDGPU_RAS_BLOCK__GFX);

			if (r)

				return r;

		}



		r = amdgpu_ras_block_late_init(adev, ras_block);

		if (r)
@@ -1005,7 +1008,10 @@ uint32_t amdgpu_kiq_rreg(struct amdgpu_device *adev, uint32_t reg, uint32_t xcc_ 
		pr_err("critical bug! too many kiq readers\n");

		goto failed_unlock;

	}

	amdgpu_ring_alloc(ring, 32);

	r = amdgpu_ring_alloc(ring, 32);

	if (r)

		goto failed_unlock;



	amdgpu_ring_emit_rreg(ring, reg, reg_val_offs);

	r = amdgpu_fence_emit_polling(ring, &seq, MAX_KIQ_REG_WAIT);

	if (r)
@@ -1071,7 +1077,10 @@ void amdgpu_kiq_wreg(struct amdgpu_device *adev, uint32_t reg, uint32_t v, uint3 
	}



	spin_lock_irqsave(&kiq->ring_lock, flags);

	amdgpu_ring_alloc(ring, 32);

	r = amdgpu_ring_alloc(ring, 32);

	if (r)

		goto failed_unlock;



	amdgpu_ring_emit_wreg(ring, reg, v);

	r = amdgpu_fence_emit_polling(ring, &seq, MAX_KIQ_REG_WAIT);

	if (r)
@@ -1107,6 +1116,7 @@ void amdgpu_kiq_wreg(struct amdgpu_device *adev, uint32_t reg, uint32_t v, uint3 


failed_undo:

	amdgpu_ring_undo(ring);

failed_unlock:

	spin_unlock_irqrestore(&kiq->ring_lock, flags);

failed_kiq_write:

	dev_err(adev->dev, "failed to write reg:%x\n", reg);