Unverified Commit c04d905f authored by Bernd Schubert's avatar Bernd Schubert Committed by Christian Brauner
Browse files

vfs: Convert BUG_ON to WARN_ON_ONCE in open_last_lookups 



The calling code actually handles -ECHILD, so this BUG_ON
can be converted to WARN_ON_ONCE.

Signed-off-by: default avatarBernd Schubert <bschubert@ddn.com>
Link: https://lore.kernel.org/r/20231023184718.11143-1-bschubert@ddn.com


Cc: Christian Brauner <brauner@kernel.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Amir Goldstein <amir73il@gmail.com>
Cc: Dharmendra Singh <dsingh@ddn.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 6654408a

fs/namei.c

+2 −1
Original line number Diff line number Diff line
@@ -3516,7 +3516,8 @@ static const char *open_last_lookups(struct nameidata *nd, 
		if (likely(dentry))

			goto finish_lookup;



		BUG_ON(nd->flags & LOOKUP_RCU);

		if (WARN_ON_ONCE(nd->flags & LOOKUP_RCU))

			return ERR_PTR(-ECHILD);

	} else {

		/* create side of things */

		if (nd->flags & LOOKUP_RCU) {