Commit c051220d authored by Ian Rogers's avatar Ian Rogers Committed by Namhyung Kim
Browse files

perf pmu: Simplify an asprintf error message 



Use ifs rather than ?: to avoid a large compound statement.

Signed-off-by: default avatarIan Rogers <irogers@google.com>
Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20241002032016.333748-2-irogers@google.com


Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
parent c7c1bb78

tools/perf/util/pmu.c

+6 −7
Original line number Diff line number Diff line
@@ -1466,13 +1466,12 @@ static int pmu_config_term(const struct perf_pmu *pmu, 
		if (err) {

			char *err_str;



			parse_events_error__handle(err, term->err_val,

				asprintf(&err_str,

			if (asprintf(&err_str,

				     "value too big for format (%s), maximum is %llu",

				    format->name, (unsigned long long)max_val) < 0

				    ? strdup("value too big for format")

				    : err_str,

				    NULL);

				     format->name, (unsigned long long)max_val) < 0) {

				err_str = strdup("value too big for format");

			}

			parse_events_error__handle(err, term->err_val, err_str, /*help=*/NULL);

			return -EINVAL;

		}

		/*