Commit c056064a authored by Ricardo Ribalda's avatar Ricardo Ribalda Committed by Hans Verkuil
Browse files

media: venus: vdec: Make the range of us_per_frame explicit 



Fps bigger than 0.000232829 fps, this fits in a 32 bit us_per_frame.
There is no need to do a 64 bit division here.
Also, the driver only works with whole fps.

Found by cocci:
drivers/media/platform/qcom/venus/vdec.c:488:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead.

Reviewed-by: default avatarVikash Garodia <quic_vgarodia@quicinc.com>
Reviewed-by: default avatarBryan O'Donoghue <bryan.odonoghue@linaro.org>
Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> # qrb5615-rb5
Signed-off-by: default avatarRicardo Ribalda <ribalda@chromium.org>
Signed-off-by: default avatarBryan O'Donoghue <bod@kernel.org>
Signed-off-by: default avatarHans Verkuil <hverkuil@xs4all.nl>
parent 3a905e52

drivers/media/platform/qcom/venus/vdec.c

+1 −2
Original line number Diff line number Diff line
@@ -482,8 +482,7 @@ static int vdec_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a) 
	do_div(us_per_frame, timeperframe->denominator);



	us_per_frame = clamp(us_per_frame, 1, USEC_PER_SEC);

	fps = (u64)USEC_PER_SEC;

	do_div(fps, us_per_frame);

	fps = USEC_PER_SEC / (u32)us_per_frame;

	fps = min(VENUS_MAX_FPS, fps);



	inst->fps = fps;