Commit c06707ff authored by Emil Tsalapatis's avatar Emil Tsalapatis Committed by Alexei Starovoitov
Browse files

selftests: bpf: fix duplicate selftests in cpumask_success. 



The BPF cpumask selftests are currently run twice in
test_progs/cpumask.c, once by traversing cpumask_success_testcases, and
once by invoking RUN_TESTS(cpumask_success). Remove the invocation of
RUN_TESTS to properly run the selftests only once.

Now that the tests are run only through cpumask_success_testscases, add
to it the missing test_refcount_null_tracking testcase. Also remove the
__success annotation from it, since it is now loaded and invoked by the
runner.

Signed-off-by: default avatarEmil Tsalapatis (Meta) <emil@etsalapatis.com>
Acked-by: default avatarHou Tao <houtao1@huawei.com>
Link: https://lore.kernel.org/r/20250309230427.26603-5-emil@etsalapatis.com


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent 014eb5c2

tools/testing/selftests/bpf/prog_tests/cpumask.c

+1 −1
Original line number Diff line number Diff line
@@ -25,6 +25,7 @@ static const char * const cpumask_success_testcases[] = { 
	"test_global_mask_nested_deep_rcu",

	"test_global_mask_nested_deep_array_rcu",

	"test_cpumask_weight",

	"test_refcount_null_tracking",

	"test_populate_reject_small_mask",

	"test_populate_reject_unaligned",

	"test_populate",
@@ -81,6 +82,5 @@ void test_cpumask(void) 
		verify_success(cpumask_success_testcases[i]);

	}



	RUN_TESTS(cpumask_success);

	RUN_TESTS(cpumask_failure);

}

tools/testing/selftests/bpf/progs/cpumask_success.c

+0 −1
Original line number Diff line number Diff line
@@ -749,7 +749,6 @@ int BPF_PROG(test_cpumask_weight, struct task_struct *task, u64 clone_flags) 
}



SEC("tp_btf/task_newtask")

__success

int BPF_PROG(test_refcount_null_tracking, struct task_struct *task, u64 clone_flags)

{

	struct bpf_cpumask *mask1, *mask2;