Commit c0793898 authored by William Tu's avatar William Tu Committed by Jakub Kicinski
Browse files

net/mlx5e: clear xdp features on non-uplink representors 



Non-uplink representor port does not support XDP. The patch clears
the xdp feature by checking the net_device_ops.ndo_bpf is set or not.

Verify using the netlink tool:
$ tools/net/ynl/cli.py --spec Documentation/netlink/specs/netdev.yaml --dump dev-get

Representor netdev before the patch:
{'ifindex': 8,
  'xdp-features': {'basic',
                   'ndo-xmit',
                   'ndo-xmit-sg',
                   'redirect',
                   'rx-sg',
                   'xsk-zerocopy'},
  'xdp-rx-metadata-features': set(),
  'xdp-zc-max-segs': 1,
  'xsk-features': set()},
With the patch:
 {'ifindex': 8,
  'xdp-features': set(),
  'xdp-rx-metadata-features': set(),
  'xsk-features': set()},

Fixes: 4d5ab0ad ("net/mlx5e: take into account device reconfiguration for xdp_features flag")
Signed-off-by: default avatarWilliam Tu <witu@nvidia.com>
Signed-off-by: default avatarTariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20241107183527.676877-6-tariqt@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent dd6e972c

drivers/net/ethernet/mellanox/mlx5/core/en_main.c

+2 −1
Original line number Diff line number Diff line
@@ -4267,7 +4267,8 @@ void mlx5e_set_xdp_feature(struct net_device *netdev) 
	struct mlx5e_params *params = &priv->channels.params;

	xdp_features_t val;



	if (params->packet_merge.type != MLX5E_PACKET_MERGE_NONE) {

	if (!netdev->netdev_ops->ndo_bpf ||

	    params->packet_merge.type != MLX5E_PACKET_MERGE_NONE) {

		xdp_clear_features_flag(netdev);

		return;

	}