Commit c08dfb1b authored by Xiubo Li's avatar Xiubo Li Committed by Ilya Dryomov
Browse files

ceph: remove the incorrect Fw reference check when dirtying pages 



When doing the direct-io reads it will also try to mark pages dirty,
but for the read path it won't hold the Fw caps and there is case
will it get the Fw reference.

Fixes: 5dda377c ("ceph: set i_head_snapc when getting CEPH_CAP_FILE_WR reference")
Signed-off-by: default avatarXiubo Li <xiubli@redhat.com>
Reviewed-by: default avatarPatrick Donnelly <pdonnell@redhat.com>
Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
parent 74249188

fs/ceph/addr.c

+0 −1
Original line number Diff line number Diff line
@@ -95,7 +95,6 @@ static bool ceph_dirty_folio(struct address_space *mapping, struct folio *folio) 


	/* dirty the head */

	spin_lock(&ci->i_ceph_lock);

	BUG_ON(ci->i_wr_ref == 0); // caller should hold Fw reference

	if (__ceph_have_pending_cap_snap(ci)) {

		struct ceph_cap_snap *capsnap =

				list_last_entry(&ci->i_cap_snaps,