Commit c0b4ddd3 authored by Jacob Keller's avatar Jacob Keller Committed by Paolo Abeni
Browse files

net: lan743x: reject unsupported external timestamp requests 



The lan743x_ptp_io_event_cap_en() function checks that the given request
sets only one of PTP_RISING_EDGE or PTP_FALLING_EDGE, but not both.

However, this driver does not check whether other flags (such as
PTP_EXT_OFF) are set, nor whether any future unrecognized flags are set.

Fix this by adding the appropriate check to the lan743x_ptp_io_extts()
function.

Fixes: 60942c39 ("net: lan743x: Add support for PTP-IO Event Input External Timestamp (extts)")
Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250312-jk-net-fixes-supported-extts-flags-v2-3-ea930ba82459@intel.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 51d58c0c

drivers/net/ethernet/microchip/lan743x_ptp.c

+6 −0
Original line number Diff line number Diff line
@@ -942,6 +942,12 @@ static int lan743x_ptp_io_extts(struct lan743x_adapter *adapter, int on, 


	extts = &ptp->extts[index];



	if (extts_request->flags & ~(PTP_ENABLE_FEATURE |

				     PTP_RISING_EDGE |

				     PTP_FALLING_EDGE |

				     PTP_STRICT_FLAGS))

		return -EOPNOTSUPP;



	if (on) {

		extts_pin = ptp_find_pin(ptp->ptp_clock, PTP_PF_EXTTS, index);

		if (extts_pin < 0)