Commit c0e4fffc authored by Robertus Diawan Chris's avatar Robertus Diawan Chris Committed by Takashi Iwai
Browse files

ALSA: scarlett2: Add missing error check when initialise Autogain Status 



When initialise new control with scarlett2_add_new_ctl() function for
Autogain Status, scarlett2_add_new_ctl() might throw an error. So, add
error check after initialise new control for Autogain Status.

This is reported by Coverity Scan with CID 1598781 as UNUSED_VALUE.

Fixes: 0a995e38 ("ALSA: scarlett2: Add support for software-controllable input gain")
Signed-off-by: default avatarRobertus Diawan Chris <robertusdchris@gmail.com>
Link: https://patch.msgid.link/20260508033914.111596-1-robertusdchris@gmail.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent fca7401f

sound/usb/mixer_scarlett2.c

+2 −0
Original line number Diff line number Diff line
@@ -6707,6 +6707,8 @@ static int scarlett2_add_line_in_ctls(struct usb_mixer_interface *mixer) 
		err = scarlett2_add_new_ctl(

			mixer, &scarlett2_autogain_status_ctl,

			i, 1, s, &private->autogain_status_ctls[i]);

		if (err < 0)

			return err;

	}



	/* Add autogain target controls */