Unverified Commit c1007dd1 authored by Hans de Goede's avatar Hans de Goede Committed by Ilpo Järvinen
Browse files

platform/x86: x86-android-tablets: Change x86_instantiate_serdev() prototype 



Make x86_instantiate_serdev() take a "struct x86_dev_info *" + idx as
arguments instead of a "struct x86_serdev_info *" + idx.

This makes the x86_instantiate_serdev() prototype match
the x86_instantiate_i2c_client() and x86_instantiate_spi_dev() prototypes.

Reviewed-by: default avatarAndy Shevchenko <andy@kernel.org>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20241204204227.95757-6-hdegoede@redhat.com


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent a6593c5c

drivers/platform/x86/x86-android-tablets/core.c

+3 −2
Original line number Diff line number Diff line
@@ -271,8 +271,9 @@ static __init int x86_instantiate_spi_dev(const struct x86_dev_info *dev_info, i 
	return 0;

}



static __init int x86_instantiate_serdev(const struct x86_serdev_info *info, int idx)

static __init int x86_instantiate_serdev(const struct x86_dev_info *dev_info, int idx)

{

	const struct x86_serdev_info *info = &dev_info->serdev_info[idx];

	struct acpi_device *serdev_adev;

	struct serdev_device *serdev;

	struct device *ctrl_dev;
@@ -446,7 +447,7 @@ static __init int x86_android_tablet_probe(struct platform_device *pdev) 


	serdev_count = dev_info->serdev_count;

	for (i = 0; i < serdev_count; i++) {

		ret = x86_instantiate_serdev(&dev_info->serdev_info[i], i);

		ret = x86_instantiate_serdev(dev_info, i);

		if (ret < 0) {

			x86_android_tablet_remove(pdev);

			return ret;