Unverified Commit c1043cdb authored by Kurt Borja's avatar Kurt Borja Committed by Ilpo Järvinen
Browse files

alienware-wmi: Fix X Series and G Series quirks 



Devices that are known to support the WMI thermal interface do not
support the legacy LED control interface. Make `.num_zones = 0` and
avoid calling alienware_zone_init() if that's the case.

Fixes: 9f6c4304 ("alienware-wmi: added platform profile support")
Fixes: 1c1eb70e ("alienware-wmi: extends the list of supported models")
Suggested-by: default avatarArmin Wolf <W_Armin@gmx.de>
Reviewed-by: default avatarArmin Wolf <W_Armin@gmx.de>
Signed-off-by: default avatarKurt Borja <kuurtb@gmail.com>
Link: https://lore.kernel.org/r/20241208002652.5885-4-kuurtb@gmail.com


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent e9fba20c

drivers/platform/x86/dell/alienware-wmi.c

+10 −5
Original line number Diff line number Diff line
@@ -190,7 +190,7 @@ static struct quirk_entry quirk_asm201 = { 
};



static struct quirk_entry quirk_g_series = {

	.num_zones = 2,

	.num_zones = 0,

	.hdmi_mux = 0,

	.amplifier = 0,

	.deepslp = 0,
@@ -199,7 +199,7 @@ static struct quirk_entry quirk_g_series = { 
};



static struct quirk_entry quirk_x_series = {

	.num_zones = 2,

	.num_zones = 0,

	.hdmi_mux = 0,

	.amplifier = 0,

	.deepslp = 0,
@@ -687,6 +687,9 @@ static void alienware_zone_exit(struct platform_device *dev) 
{

	u8 zone;



	if (!quirks->num_zones)

		return;



	sysfs_remove_group(&dev->dev.kobj, &zone_attribute_group);

	led_classdev_unregister(&global_led);

	if (zone_dev_attrs) {
@@ -1229,9 +1232,11 @@ static int __init alienware_wmi_init(void) 
			goto fail_prep_thermal_profile;

	}



	if (quirks->num_zones > 0) {

		ret = alienware_zone_init(platform_device);

		if (ret)

			goto fail_prep_zones;

	}



	return 0;