Commit c1151691 authored by Lucas De Marchi's avatar Lucas De Marchi
Browse files

drm/xe/reg_sr: Stop setting all whitelist slots 



Currently xe_reg_sr_apply_whitelist() sets the unused values to a known
used value for no good reason: it could just leave it with the HW
default. The behavior is slightly different if there are no whitelist
registers for the engine as the function returns early. This is not
needed, so just drop the addition writes for the unused slots.

Later this will allow to reduce the amount of registers passed to GuC
for save/restore.

Reviewed-by: default avatarMatt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241209232739.147417-5-lucas.demarchi@intel.com


Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
parent bd022199

drivers/gpu/drm/xe/xe_reg_sr.c

+0 −7
Original line number Diff line number Diff line
@@ -227,13 +227,6 @@ void xe_reg_sr_apply_whitelist(struct xe_hw_engine *hwe) 
		slot++;

	}



	/* And clear the rest just in case of garbage */

	for (; slot < RING_MAX_NONPRIV_SLOTS; slot++) {

		u32 addr = RING_NOPID(mmio_base).addr;



		xe_mmio_write32(&gt->mmio, RING_FORCE_TO_NONPRIV(mmio_base, slot), addr);

	}



	xe_force_wake_put(gt_to_fw(gt), fw_ref);



	return;