Unverified Commit c16a4823 authored by Armin Wolf's avatar Armin Wolf Committed by Ilpo Järvinen
Browse files

platform/x86: uniwill-laptop: Accept charging threshold of 0 



The power supply sysfs ABI states that:

	Not all hardware is capable of setting this to an arbitrary
	percentage. Drivers will round written values to the nearest
	supported value. Reading back the value will show the actual
	threshold set by the driver.

The driver currently violates this ABI by rejecting a charging
threshold of 0. Fix this by clamping this value to 1.

Fixes: d0504796 ("platform/x86: Add Uniwill laptop driver")
Reviewed-by: default avatarWerner Sembach <wse@tuxedocomputers.com>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarArmin Wolf <W_Armin@gmx.de>
Link: https://patch.msgid.link/20260512232145.329260-3-W_Armin@gmx.de


Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent c12cc42d

drivers/platform/x86/uniwill/uniwill-acpi.c

+2 −2
Original line number Diff line number Diff line
@@ -1431,11 +1431,11 @@ static int uniwill_set_property(struct power_supply *psy, const struct power_sup 


	switch (psp) {

	case POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD:

		if (val->intval < 1 || val->intval > 100)

		if (val->intval < 0 || val->intval > 100)

			return -EINVAL;



		return regmap_update_bits(data->regmap, EC_ADDR_CHARGE_CTRL, CHARGE_CTRL_MASK,

					  val->intval);

					  max(val->intval, 1));

	default:

		return -EINVAL;

	}