Commit c1822fb6 authored by Dheeraj Reddy Jonnalagadda's avatar Dheeraj Reddy Jonnalagadda Committed by Jakub Kicinski
Browse files

wireguard: allowedips: remove redundant selftest call 



This commit fixes a useless call issue detected by Coverity (CID
1508092). The call to horrible_allowedips_lookup_v4 is unnecessary as
its return value is never checked.

Signed-off-by: default avatarDheeraj Reddy Jonnalagadda <dheeraj.linuxdev@gmail.com>
Fixes: e7096c13 ("net: WireGuard secure network tunnel")
Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
Link: https://patch.msgid.link/20241117212030.629159-3-Jason@zx2c4.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 2c862914

drivers/net/wireguard/selftest/allowedips.c

+0 −1
Original line number Diff line number Diff line
@@ -383,7 +383,6 @@ static __init bool randomized_test(void) 
		for (i = 0; i < NUM_QUERIES; ++i) {

			get_random_bytes(ip, 4);

			if (lookup(t.root4, 32, ip) != horrible_allowedips_lookup_v4(&h, (struct in_addr *)ip)) {

				horrible_allowedips_lookup_v4(&h, (struct in_addr *)ip);

				pr_err("allowedips random v4 self-test: FAIL\n");

				goto free;

			}