Commit c18f35e4 authored by FUJITA Tomonori's avatar FUJITA Tomonori Committed by Miguel Ojeda
Browse files

objtool/rust: add one more `noreturn` Rust function 



Fix the following warning:

rust/kernel.o: warning: objtool: _RNvXNtNtCs1ewLyjEZ7Le_6kernel3str9parse_intaNtNtB2_7private12FromStrRadix14from_str_radix()
falls through to next function _RNvXNtNtCs1ewLyjEZ7Le_6kernel3str9parse_intaNtNtB2_7private12FromStrRadix16from_u64_negated()

The commit 51d9ee90 ("rust: str: add radix prefixed integer
parsing functions") introduces u64::from_str_radix(), whose
implementation contains a panic path for out-of-range radix values.
The panic helper is core::num::from_ascii_radix_panic().

Note that radix is derived from strip_radix() here and is always
within the valid range, so kernel never panics.

Fixes: 51d9ee90 ("rust: str: add radix prefixed integer parsing functions")
Signed-off-by: default avatarFUJITA Tomonori <fujita.tomonori@gmail.com>
Reviewed-by: default avatarAlice Ryhl <aliceryhl@google.com>
Tested-by: default avatarAlice Ryhl <aliceryhl@google.com>
Link: https://patch.msgid.link/20251223113538.1016078-1-fujita.tomonori@gmail.com


[ Reworded typo. - Miguel ]
Signed-off-by: default avatarMiguel Ojeda <ojeda@kernel.org>
parent f1db6538

tools/objtool/check.c

+2 −1
Original line number Diff line number Diff line
@@ -197,7 +197,8 @@ static bool is_rust_noreturn(const struct symbol *func) 
	 * as well as changes to the source code itself between versions (since

	 * these come from the Rust standard library).

	 */

	return str_ends_with(func->name, "_4core5sliceSp15copy_from_slice17len_mismatch_fail")		||

	return str_ends_with(func->name, "_4core3num22from_ascii_radix_panic")				||

	       str_ends_with(func->name, "_4core5sliceSp15copy_from_slice17len_mismatch_fail")		||

	       str_ends_with(func->name, "_4core6option13expect_failed")				||

	       str_ends_with(func->name, "_4core6option13unwrap_failed")				||

	       str_ends_with(func->name, "_4core6result13unwrap_failed")				||