Commit c19278d6 authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/i915: Use debugfs_create_bool() for "i915_bigjoiner_force_enable" 



There is no reason to make this debugfs file for a simple
boolean so complicated. Just use debugfs_create_bool().

Reviewed-by: default avatarArun R Murthy <arun.r.murthy@intel.com>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240402135148.23011-8-ville.syrjala@linux.intel.com
parent b648ce2a

drivers/gpu/drm/i915/display/intel_display_debugfs.c

+2 −42
Original line number Diff line number Diff line
@@ -1402,20 +1402,6 @@ out: drm_modeset_unlock(&i915->drm.mode_config.connection_mutex); 
	return ret;

}



static int i915_bigjoiner_enable_show(struct seq_file *m, void *data)

{

	struct intel_connector *connector = m->private;

	struct drm_crtc *crtc;



	crtc = connector->base.state->crtc;

	if (connector->base.status != connector_status_connected || !crtc)

		return -ENODEV;



	seq_printf(m, "Bigjoiner enable: %d\n", connector->force_bigjoiner_enable);



	return 0;

}



static ssize_t i915_dsc_output_format_write(struct file *file,

					    const char __user *ubuf,

					    size_t len, loff_t *offp)
@@ -1437,30 +1423,6 @@ static ssize_t i915_dsc_output_format_write(struct file *file, 
	return len;

}



static ssize_t i915_bigjoiner_enable_write(struct file *file,

					   const char __user *ubuf,

					   size_t len, loff_t *offp)

{

	struct seq_file *m = file->private_data;

	struct intel_connector *connector = m->private;

	struct drm_crtc *crtc;

	bool bigjoiner_en = 0;

	int ret;



	crtc = connector->base.state->crtc;

	if (connector->base.status != connector_status_connected || !crtc)

		return -ENODEV;



	ret = kstrtobool_from_user(ubuf, len, &bigjoiner_en);

	if (ret < 0)

		return ret;



	connector->force_bigjoiner_enable = bigjoiner_en;

	*offp += len;



	return len;

}



static int i915_dsc_output_format_open(struct inode *inode,

				       struct file *file)

{
@@ -1554,8 +1516,6 @@ static const struct file_operations i915_dsc_fractional_bpp_fops = { 
	.write = i915_dsc_fractional_bpp_write

};



DEFINE_SHOW_STORE_ATTRIBUTE(i915_bigjoiner_enable);



/*

 * Returns the Current CRTC's bpc.

 * Example usage: cat /sys/kernel/debug/dri/0/crtc-0/i915_current_bpc
@@ -1640,8 +1600,8 @@ void intel_connector_debugfs_add(struct intel_connector *connector) 
	if (DISPLAY_VER(i915) >= 11 &&

	    (connector_type == DRM_MODE_CONNECTOR_DisplayPort ||

	     connector_type == DRM_MODE_CONNECTOR_eDP)) {

		debugfs_create_file("i915_bigjoiner_force_enable", 0644, root,

				    connector, &i915_bigjoiner_enable_fops);

		debugfs_create_bool("i915_bigjoiner_force_enable", 0644, root,

				    &connector->force_bigjoiner_enable);

	}



	if (connector_type == DRM_MODE_CONNECTOR_DSI ||