Commit c1a32a04 authored by Adrián Larumbe's avatar Adrián Larumbe Committed by Boris Brezillon
Browse files

drm/panthor: Fix build warning when DEBUG_FS is disabled 



Commit a3707f53 ("drm/panthor: show device-wide list of DRM GEM
objects over DebugFS") causes a build warning and linking error when
built without support for DebugFS, because of a non-inline non-static
function declaration in a header file.

On top of that, the function is only being used inside a single
compilation unit, so there is no point in exposing it as a global
symbol.

This is a follow-up from Arnd Bergmann's first fix.
Also move panthor_gem_debugfs_set_usage_flags() into panthor_gem.c and
declare it static.

Fixes: a3707f53 ("drm/panthor: show device-wide list of DRM GEM objects over DebugFS")
Reported-by: default avatarArnd Bergmann <arnd@arndb.de>
Closes: https://lore.kernel.org/dri-devel/20250424142419.47b9d457@collabora.com/T/#t


Signed-off-by: default avatarAdrián Larumbe <adrian.larumbe@collabora.com>
Reviewed-by: default avatarSteven Price <steven.price@arm.com>
Reviewed-by: default avatarLiviu Dudau <liviu.dudau@arm.com>
Link: https://lore.kernel.org/r/20250424184041.356191-1-adrian.larumbe@collabora.com


Signed-off-by: default avatarBoris Brezillon <boris.brezillon@collabora.com>
parent de5fbbe1

drivers/gpu/drm/panthor/panthor_gem.c

+5 −0
Original line number Diff line number Diff line
@@ -42,11 +42,16 @@ static void panthor_gem_debugfs_bo_rm(struct panthor_gem_object *bo) 
	mutex_unlock(&ptdev->gems.lock);

}



static void panthor_gem_debugfs_set_usage_flags(struct panthor_gem_object *bo, u32 usage_flags)

{

	bo->debugfs.flags = usage_flags | PANTHOR_DEBUGFS_GEM_USAGE_FLAG_INITIALIZED;

}

#else

static void panthor_gem_debugfs_bo_add(struct panthor_device *ptdev,

				       struct panthor_gem_object *bo)

{}

static void panthor_gem_debugfs_bo_rm(struct panthor_gem_object *bo) {}

static void panthor_gem_debugfs_set_usage_flags(struct panthor_gem_object *bo, u32 usage_flags) {}

#endif



static void panthor_gem_free_object(struct drm_gem_object *obj)

drivers/gpu/drm/panthor/panthor_gem.h

+0 −8
Original line number Diff line number Diff line
@@ -212,14 +212,6 @@ void panthor_kernel_bo_destroy(struct panthor_kernel_bo *bo); 
#ifdef CONFIG_DEBUG_FS

void panthor_gem_debugfs_print_bos(struct panthor_device *pfdev,

				   struct seq_file *m);

static inline void

panthor_gem_debugfs_set_usage_flags(struct panthor_gem_object *bo, u32 usage_flags)

{

	bo->debugfs.flags = usage_flags | PANTHOR_DEBUGFS_GEM_USAGE_FLAG_INITIALIZED;

}



#else

void panthor_gem_debugfs_set_usage_flags(struct panthor_gem_object *bo, u32 usage_flags) {};

#endif



#endif /* __PANTHOR_GEM_H__ */