Commit c207f1d7 authored by David Howells's avatar David Howells Committed by Steve French
Browse files

smbdirect: Fix error cleanup in smbdirect_map_sges_from_iter() 

Fix smbdirect_map_sges_from_iter() to use pre-decrement, not post-decrement
so that it cleans up the correct slots.

Fixes: e5fbdde4 ("cifs: Add a function to build an RDMA SGE list from an iterator")
Closes: https://sashiko.dev/#/patchset/20260326104544.509518-1-dhowells%40redhat.com


Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Reviewed-by: default avatarStefan Metzmacher <metze@samba.org>
cc: Paulo Alcantara <pc@manguebit.org>
cc: Tom Talpey <tom@talpey.com>
cc: linux-cifs@vger.kernel.org
cc: linux-fsdevel@vger.kernel.org
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 81a87423

fs/smb/smbdirect/connection.c

+1 −1
Original line number Diff line number Diff line
@@ -2168,7 +2168,7 @@ static ssize_t smbdirect_map_sges_from_iter(struct iov_iter *iter, size_t len, 


	if (ret < 0) {

		while (state->num_sge > before) {

			struct ib_sge *sge = &state->sge[state->num_sge--];

			struct ib_sge *sge = &state->sge[--state->num_sge];



			ib_dma_unmap_page(state->device,

					  sge->addr,