Commit c21b02fd authored by Florian Westphal's avatar Florian Westphal Committed by Pablo Neira Ayuso
Browse files

selftests: netfilter: skip br_netfilter queue tests if kernel is tainted 



These scripts fail if the kernel is tainted which leads to wrong test
failure reports in CI environments when an unrelated test triggers some
splat.

Check taint state at start of script and SKIP if its already dodgy.

Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent d653bfeb

tools/testing/selftests/net/netfilter/br_netfilter.sh

+7 −0
Original line number Diff line number Diff line
@@ -13,6 +13,12 @@ source lib.sh 


checktool "nft --version" "run test without nft tool"



read t < /proc/sys/kernel/tainted

if [ "$t" -ne 0 ];then

	echo SKIP: kernel is tainted

	exit $ksft_skip

fi



cleanup() {

	cleanup_all_ns

}
@@ -165,6 +171,7 @@ if [ "$t" -eq 0 ];then 
	echo PASS: kernel not tainted

else

	echo ERROR: kernel is tainted

	dmesg

	ret=1

fi

tools/testing/selftests/net/netfilter/br_netfilter_queue.sh

+7 −0
Original line number Diff line number Diff line
@@ -4,6 +4,12 @@ source lib.sh 


checktool "nft --version" "run test without nft tool"



read t < /proc/sys/kernel/tainted

if [ "$t" -ne 0 ];then

	echo SKIP: kernel is tainted

	exit $ksft_skip

fi



cleanup() {

	cleanup_all_ns

}
@@ -72,6 +78,7 @@ if [ "$t" -eq 0 ];then 
	echo PASS: kernel not tainted

else

	echo ERROR: kernel is tainted

	dmesg

	exit 1

fi

tools/testing/selftests/net/netfilter/nft_queue.sh

+1 −0
Original line number Diff line number Diff line
@@ -593,6 +593,7 @@ EOF 
		echo "PASS: queue program exiting while packets queued"

	else

		echo "TAINT: queue program exiting while packets queued"

		dmesg

		ret=1

	fi

}