Commit c229d579 authored by Uladzislau Rezki (Sony)'s avatar Uladzislau Rezki (Sony) Committed by Frederic Weisbecker
Browse files

rcuscale: Remove redundant WARN_ON_ONCE() splat 



There are two places where WARN_ON_ONCE() is called two times
in the error paths. One which is encapsulated into if() condition
and another one, which is unnecessary, is placed in the brackets.

Remove an extra WARN_ON_ONCE() splat which is in brackets.

Reviewed-by: default avatarPaul E. McKenney <paulmck@kernel.org>
Reviewed-by: default avatarNeeraj Upadhyay <Neeraj.Upadhyay@amd.com>
Signed-off-by: default avatarUladzislau Rezki (Sony) <urezki@gmail.com>
Signed-off-by: default avatarFrederic Weisbecker <frederic@kernel.org>
parent 812a1c3b

kernel/rcu/rcuscale.c

+0 −2
Original line number Diff line number Diff line
@@ -889,14 +889,12 @@ kfree_scale_init(void) 


		if (WARN_ON_ONCE(jiffies_at_lazy_cb - jif_start < 2 * HZ)) {

			pr_alert("ERROR: call_rcu() CBs are not being lazy as expected!\n");

			WARN_ON_ONCE(1);

			firsterr = -1;

			goto unwind;

		}



		if (WARN_ON_ONCE(jiffies_at_lazy_cb - jif_start > 3 * HZ)) {

			pr_alert("ERROR: call_rcu() CBs are being too lazy!\n");

			WARN_ON_ONCE(1);

			firsterr = -1;

			goto unwind;

		}